Re: [PATCH] tree wide: Use kvfree() than conditional kfree()/vfree()

From: Dilger, Andreas
Date: Mon Nov 09 2015 - 15:41:13 EST


On 2015/11/09, 04:56, "Tetsuo Handa" <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
wrote:

>There are many locations that do
>
> if (memory_was_allocated_by_vmalloc)
> vfree(ptr);
> else
> kfree(ptr);
>
>but kvfree() can handle both kmalloc()ed memory and vmalloc()ed memory
>using is_vmalloc_addr(). Unless callers have special reasons, we can
>replace this branch with kvfree(). Please check and reply if you found
>problems.
>
>Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
>Acked-by: Michal Hocko <mhocko@xxxxxxxx>

For Lustre part:
Reviewed-by: Andreas Dilger <andreas.dilger@xxxxxxxxx>

Cheers, Andreas
--
Andreas Dilger

Lustre Principal Engineer
Intel High Performance Data Division


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/