Re: [PATCH 0/4] nvdimm: Add an IOCTL pass thru for DSM calls

[Jeff Moyer]

Jerry Hoemann <jerry.hoemann@xxxxxxx> writes:

> The NVDIMM code in the kernel supports an IOCTL interface to user
> space based upon the Intel Example DSM:
>
> 	http://pmem.io/documents/NVDIMM_DSM_Interface_Example.pdf
>
> This interface cannot be used by other NVDIMM DSMs that support
> incompatible functions.
>
> This patch set adds a generic "passthru" IOCTL interface which
> is not tied to a particular DSM.
>
> A new IOCTL type "P" is added for the pass thru call.
>
> The new data structure ndn_pkg serves as a wrapper for the passthru
> calls.  This wrapper supplies the data that the kernel needs to
> make the _DSM call.

What does 'ndn' stand for?  If it stands for NVDIMM-N, then I think
that's too narrow a scope.  Anyway, it helps readability if you call out
what abbreviations mean, especially when it's non-obvious.

> Jerry Hoemann (4):
>   nvdimm: Add wrapper for IOCTL pass thru.
>   nvdimm: Add IOCTL pass thru
>   nvdimm: Add IOCTL pass thru

You should really give each patch a different subject.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/