Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

[Shi, Yang]

On 11/10/2015 2:37 AM, Catalin Marinas wrote:
> On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote:
> > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine
> > it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory
> > is never used.
>
> That's not true since the arm64 definition seems to take precedence.
>
> > This adds a dependency on DEBUG_KERNEL for building with frame pointers.
>
> It doesn't because arm64 selects ARCH_WANT_FRAME_POINTERS.

Thanks for pointing it out. I misread the order of precedence, still 
think of C syntax at the first place.

Yang

> > ARM64 depends on frame pointer to get correct stack backtrace and need
> > FRAME_POINTER kconfig option enabled all the time.
> > However, currect implementation makes it could be disabled, so force it
> > to be selected by ARM64.
> >
> > Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxx>
>
> Patch applied but I changed the commit log slightly. Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/