Re: [PATCH 2/4] nvdimm: Add IOCTL pass thru

[Jeff Moyer]

Jerry Hoemann <jerry.hoemann@xxxxxxx> writes:

> Add internal data structure for ndctl_passthru call.
>
> Signed-off-by: Jerry Hoemann <jerry.hoemann@xxxxxxx>
> ---
>  include/linux/libnvdimm.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/include/linux/libnvdimm.h b/include/linux/libnvdimm.h
> index 3f021dc..01117e1 100644
> --- a/include/linux/libnvdimm.h
> +++ b/include/linux/libnvdimm.h
> @@ -72,6 +72,7 @@ struct nvdimm_bus_descriptor {
>  	unsigned long dsm_mask;
>  	char *provider_name;
>  	ndctl_fn ndctl;
> +	ndctl_fn ndctl_passthru;

I don't think this is necessary.  Vector off inside of __nd_ioctl.  That
especially makes sense if you do switch to passthrough as a command
instead of a type, but it can work either way.

-Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/