Re: [PATCH 3/4] nvdimm: Add IOCTL pass thru

From: Jerry Hoemann
Date: Tue Nov 10 2015 - 20:42:47 EST

On Tue, Nov 10, 2015 at 04:54:28PM -0500, Jeff Moyer wrote:
> Jerry Hoemann <jerry.hoemann@xxxxxxx> writes:
> > + uuid = pkg->h.dsm_uuid;
> > + rev = pkg->h.dsm_rev ? pkg->h.dsm_rev : 1;
> Shouldn't revision id be required?

Yes it should be. Good catch.

I was testing use of reclaiming previously unused members of
the structure. I should have removed this line.

And this reminds me that I should also add a test that the reserved fields
of ndn_pkg are actually zero.

I'll address both in version 2.



Jerry Hoemann Software Engineer Hewlett-Packard Enterprise
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at