Re: [PATCH] KVM: x86: fix eflags state following processor init/reset

[Wanpeng Li]

2015-11-03 18:47 GMT+08:00 Paolo Bonzini <pbonzini@xxxxxxxxxx>:
>
>
> On 28/10/2015 09:10, Nadav Amit wrote:
>> Here are my 5 cents. Note that vmx_vcpu_reset calls:
>>
>>       vmcs_writel(GUEST_RFLAGS, 0x02);
>>
>> (And the RFLAGS value is not cached by KVM, so no consistency problem should
>> occur.)
>>
>> You may want to change the value into constant or call a wrapper function
>> for setting RFLAGS, but I donât see something broken in the functionality.
>
> I agree.  Wanpeng, if this is just a cleanup, can you send v2 that
> removes or modifies the existing call to vmcs_writel?  If there is a
> bug, can you write a unit test for it?  It should be possible to test
> for the problem using INIT+SIPI on an AP.

You are right, I write a INIT+SIPI kvm-unit-test and didn't trigger
any bug. Please ignore the patch.

Regards,
Wanpeng Li
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/