Re: [PATCH 1/1] dmaengine: imx-sdma: remove __init annotation on sdma_event_remap
From: Arnd Bergmann
Date: Wed Nov 11 2015 - 05:02:28 EST
On Wednesday 11 November 2015 17:20:49 Jason Liu wrote:
> The sdma_probe function will call sdma_event_remap, but sdma_event_remap
> marked with the __init annotation which make the kbuild complains as the
> following log:
> WARNING: drivers/dma/built-in.o(.text+0x56fc): Section mismatch in reference
> from the function sdma_probe() to the function .init.text:sdma_event_remap()
> The function sdma_probe() references
> the function __init sdma_event_remap().
> This is often because sdma_probe lacks a __init
> annotation or the annotation of sdma_event_remap is wrong.
> Remove the __init annotation on sdma_event_remap to kill this build warning
> Signed-off-by: Jason Liu <r64343@xxxxxxxxxxxxx>
> Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Looks good. I wonder why I have not caught this with the randconfig builds yet.
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
One hint for the future: in the patch description, write less about the
kbuild warning and more about the actual impact of the bug (calling a
discarded function if the device gets unbound and rebound later, or
if we get deferred probing).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/