Re: [PATCH v2 05/12] staging: rtl8188eu: kzalloc replaced by kmalloc

From: Ivan Safonov
Date: Wed Nov 11 2015 - 05:16:12 EST

On 11/11/2015 04:43 PM, Dan Carpenter wrote:
On Sun, Nov 08, 2015 at 02:11:08PM +0700, Ivan Safonov wrote:
_rtl88e_fill_dummy fills the array elemets with zeros if necessary.

_rtl88e_fill_dummy() fills the last sizeof(u32) or whatever so the code
is aligned but it doesn't fill up to the end of FW_8188E_SIZE. Why do
we even allocate that much memory. Why don't we just allocate:

pfwdata = kmalloc(round_up(fwsize, sizeof(u32)), GFP_KERNEL);

dan carpenter

Yes, it will save about 2 KB. I will correct it in the next patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at