[PATCH] perf probe: Clear probe_trace_event when probe_trace_event failure

From: Wang Nan
Date: Wed Nov 11 2015 - 05:20:28 EST

When failure occures in add_probe_trace_event(), to avoid potential
dangling pointer and memory leak, resource attached to 'struct
probe_trace_event' should be cleared.

Signed-off-by: Wang Nan <wangnan0@xxxxxxxxxx>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
Cc: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
Cc: Zefan Li <lizefan@xxxxxxxxxx>
Cc: pi3orama@xxxxxxx
tools/perf/util/probe-finder.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
index bd8f03d..e9e37ca 100644
--- a/tools/perf/util/probe-finder.c
+++ b/tools/perf/util/probe-finder.c
@@ -1235,6 +1235,8 @@ static int add_probe_trace_event(Dwarf_Die *sc_die, struct probe_finder *pf)

+ if (ret)
+ clear_probe_trace_event(tev);
return ret;


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/