Re: [PATCH v3 1/5] Implement an ioctl to support the USMTMC-USB488 READ_STATUS_BYTE operation.

From: Greg Kroah-Hartman
Date: Wed Nov 11 2015 - 16:09:33 EST

On Wed, Nov 11, 2015 at 09:03:14PM +0200, Andy Shevchenko wrote:
> On Wed, Nov 11, 2015 at 1:16 PM, Dave Penkler <dpenkler@xxxxxxxxx> wrote:
> > Background:
> > When performing a read on an instrument that is executing a function
> > that runs longer than the USB timeout the instrument may hang and require
> > a device reset to recover. The READ_STATUS_BYTE operation always returns
> > even when the instrument is busy permitting to poll for the appropriate
> > condition. This capability is refered to in instrument application notes
> > on synchronizing acquisitions for other platforms.
> >
> Won't comment precisely by line, but common nitpicks about style:
> - added empty lines where no need
> - redundant parens
> - pieces of code takes whole line when they are quite fit tail of previous one.
> And why malloc for 8 bytes?

That's a requirement of the USB stack, any data you send on it has to be

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at