Re: [RFC 1/4] iio: ina2xx: add direct IO support for TI INA2xx Power Monitors

[Marc Titinger]

On 11/11/2015 13:09, Daniel Baluta wrote:
> <snip>
>
> > Signed-off-by: Marc Titinger <mtitinger@xxxxxxxxxxxx>
> > ---
> >   drivers/iio/adc/Kconfig      |   9 +
> >   drivers/iio/adc/Makefile     |   1 +
> >   drivers/iio/adc/ina2xx-iio.c | 404 +++++++++++++++++++++++++++++++++++++++++++
>
> One more thing. In IIO we do not prefer generic names for files.
> Lets name this after the first device in the family.
>
> Here I would say we should call it drivers/iio/adc/ina219.c. Skip the
> -iio suffix
> from file name, because it is already under the iio/ directory.

I get your point, but in this specific case there is already support for 
this chip family in hwmon and both drivers make sense because both 
applications exist (hardware monitoring or power measurement equipement).

To avoid confusion it may be good to have at least a common radix for 
the CONFIG option, so that searching returns both options.

> If there is a module name conflict with hwmon module we can name the
> .ko resulted
> from this file ina219-iio.ko.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/