Re: [PATCH] FS-Cache: Add missing initialization of ret in cachefiles_write_page()

From: Geert Uytterhoeven
Date: Thu Nov 12 2015 - 05:43:45 EST

On Thu, Nov 12, 2015 at 11:42 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
> Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
>> > This isn't quite the right solution. The uninitialised error path needs to
>> > set -ENOBUFS.
>> That's what your commit 102f4d900c9c8f5e ("FS-Cache: Handle a write to the
>> page immediately beyond the EOF marker") does, and is also in its commit
>> description:
>> Whilst we're at it, change the triggered assertion in CacheFiles to just
>> return -ENOBUFS instead.
>> "ret" is used only to print the original error in a debug message.
> I'll adjust your patch to set the default value in ret to be -ENOBUFS instead
> of 0.

OK. Thanks!



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at