Re: [PATCH] spi: bcm63xx: use correct format string for printing a resource
From: Florian Fainelli
Date: Thu Nov 12 2015 - 13:41:18 EST
On 12/11/15 08:44, Arnd Bergmann wrote:
> With a 64-bit resource_size_t, we get a build warning on bcm63xx_spi_probe:
>
> drivers/spi/spi-bcm63xx.c:565:16: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
>
> As we are printing a resource, we can just use the %pr format
> specifier that pretty-prints the address and avoids the warning.
>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Thanks
> ---
> Found on arm multi_v7_defconfig with LPAE
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index 06858e04ec59..bf9a610e5b89 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -562,8 +562,8 @@ static int bcm63xx_spi_probe(struct platform_device *pdev)
> goto out_clk_disable;
> }
>
> - dev_info(dev, "at 0x%08x (irq %d, FIFOs size %d)\n",
> - r->start, irq, bs->fifo_size);
> + dev_info(dev, "at %pr (irq %d, FIFOs size %d)\n",
> + r, irq, bs->fifo_size);
>
> return 0;
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/