Re: module: save load_info for livepatch modules

From: Miroslav Benes
Date: Fri Nov 13 2015 - 07:56:42 EST

On Fri, 13 Nov 2015, Miroslav Benes wrote:

> I agree this seems like the best approach. So if we preserve
> mod_arch_syminfo (in case of s390) we should free it not in
> module_finalize, but somewhere in free_module... where
> module_arch_cleanup() is called... and also module_arch_freeing_init() is
> called there too. And what you find there for s390 is
> vfree(mod->arch.syminfo);
> mod->arch.syminfo = NULL;
> Well, it does nothing here, because mod->arch.syminfo is already NULL. It
> was freed in module_finalize. So we can even remove this code from
> module_finalize and all should be fine. At least for s390.

Which is not true because module_arch_freeing_init is also called from
do_init_module, called from load_module. So we should move it to

That code is like a maze without Ariadne's thread.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at