Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init

From: Daniel Lezcano
Date: Fri Nov 13 2015 - 09:18:51 EST

On 11/13/2015 02:33 PM, Marc Gonzalez wrote:
On 13/11/2015 11:58, Daniel Lezcano wrote:

The current code to initialize, register and read the clocksource is
already factored out in mmio.c via the clocksource_mmio_init function.

Factor out the code with the clocksource_mmio_init function.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
drivers/clocksource/tango_xtal.c | 18 +++---------------
1 file changed, 3 insertions(+), 15 deletions(-)

Hello Daniel,

I think you also need:

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 63c878d4d9e3..92bf3fc3e646 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -278,6 +278,7 @@ config CLKSRC_MIPS_GIC
select CLKSRC_OF
+ select CLKSRC_MMIO

def_bool y if ARCH_PXA || ARCH_SA1100

Otherwise, we'll get "undefined reference" link errors.

Ok, thanks for spotting that. It did not happen because the dependency was set by another driver (using COMPILE_TEST).

Will fix it.

-- Daniel

<> â Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at