Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init

[Daniel Lezcano]

On 11/13/2015 12:31 AM, Maxime Ripard wrote:
> On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote:
> > The current code to initialize, register and read the clocksource is
> > already factored out in mmio.c via the clocksource_mmio_init function.
> >
> > The only difference is the readl vs readl_relaxed.
> >
> > Factor out the code with the clocksource_mmio_init function.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
>
> Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

Thanks for the review. I applied the patch with a fix:

ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1),
			node->name,
			rate, 340, UINT_MAX,
			clocksource_mmio_readl_down);

Replaced UINT_MAX by '32'.

  -- Daniel

--
 <http://www.linaro.org/> Linaro.org â Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/