Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init

From: Daniel Lezcano
Date: Fri Nov 13 2015 - 09:27:47 EST

On 11/13/2015 12:31 AM, Maxime Ripard wrote:
On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote:
The current code to initialize, register and read the clocksource is
already factored out in mmio.c via the clocksource_mmio_init function.

The only difference is the readl vs readl_relaxed.

Factor out the code with the clocksource_mmio_init function.

Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>

Acked-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>

Thanks for the review. I applied the patch with a fix:

ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1),
rate, 340, UINT_MAX,

Replaced UINT_MAX by '32'.

-- Daniel

<> â Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at