Re: [PATCH] mm: get rid of __alloc_pages_high_priority

From: David Rientjes
Date: Fri Nov 13 2015 - 17:31:17 EST

On Fri, 13 Nov 2015, Michal Hocko wrote:

> > > Hi,
> > > I think that this is more a cleanup than any functional change. We
> > > are rarely screwed so much that __alloc_pages_high_priority would
> > > fail. Yet I think that __alloc_pages_high_priority is obscuring the
> > > overal intention more than it is helpful. Another motivation is to
> > > reduce wait_iff_congested call to a single one in the allocator. I plan
> > > to do other changes in that area and get rid of it altogether.
> >
> > I think it's a combination of a cleanup (the inlining of
> > __alloc_pages_high_priority) and a functional change (no longer looping
> > infinitely around a get_page_from_freelist() call). I'd suggest doing the
> > inlining in one patch and then the reworking of __GFP_NOFAIL when
> > ALLOC_NO_WATERMARKS fails just so we could easily revert the latter if
> > necessary.
> I can split it up if this is really preferable of course.

I think it's preferable.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at