Re: [PATCH] lightnvm: change max_phys_sect to ushort

[Matias BjÃrling]

On 11/16/2015 12:18 PM, Thiago Farina wrote:
> On Thu, Nov 12, 2015 at 4:35 PM, Matias BjÃrling <m@xxxxxxxxxxx> wrote:
> > The max_phys_sect variable is defined as a char. We do a boundary check
> > to maximally allow 256 physical page descriptors per command. As we are
> > not indexing from zero. This expression is always in false. Bump the
> > max_phys_sect to an unsigned short to support the range check.
> You might have to change the commit message to match the code change.
> s/unsigned short/unsigned int. RIght?

You're right. It has been fixed.

> > Signed-off-by: Matias BjÃrling <m@xxxxxxxxxxx>
> > Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > ---
> >   include/linux/lightnvm.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
> > index 69c9057..4b1cd3d 100644
> > --- a/include/linux/lightnvm.h
> > +++ b/include/linux/lightnvm.h
> > @@ -220,7 +220,7 @@ struct nvm_dev_ops {
> >          nvm_dev_dma_alloc_fn    *dev_dma_alloc;
> >          nvm_dev_dma_free_fn     *dev_dma_free;
> >
> > -       uint8_t                 max_phys_sect;
> > +       unsigned int max_phys_sect;
> >   };
> >
> >   struct nvm_lun {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/