Re: [PATCH 00/13] perf tools: bpf: Improve BPF program ability

From: Arnaldo Carvalho de Melo
Date: Mon Nov 16 2015 - 09:13:53 EST


Em Mon, Nov 16, 2015 at 12:10:02PM +0000, Wang Nan escreveu:
> Resend patch set in [1] with sereval improvements based on Arnaldo's
> suggestions. This patch set is based on Arnaldo's perf/core.
>
> Patch 1/13 - 2/13 should have already been collected by Arnaldo but
> I can't find them in his repository, so I resend them.

Sorry, I have it in my perf/urgent branch and the latest signed tag
(perf-urgent-for-mingo), but I only pushed the later, just pushed the
former now.

Ingo should process those two soon, as they are purely bug fixes. I'll
go through this new patchkit now, thanks for considering my suggestions.

- Arnaldo

> Patch 3/13 - 6/13 are improved according to Arnaldo's suggestion: Some
> lines are made compat, return values of strdup() are checked, use
> named initializers. In addition, error messages are improved to reduce
> confusion.
>
> Patch 7/13 - 13/13 are identical to previous version, only cc-lists are
> shrinked.
>
> [1] http://lkml.kernel.org/g/1447417761-156094-1-git-send-email-wangnan0@xxxxxxxxxx
>
> He Kuang (1):
> perf tools: Add prologue for BPF programs for fetching arguments
>
> Masami Hiramatsu (1):
> perf probe: Fix memory leaking on faiulre by clearing all
> probe_trace_events
>
> Wang Nan (11):
> perf probe: Clear probe_trace_event when add_probe_trace_event() fails
> perf tools: Allow BPF program attach to uprobe events
> perf tools: Allow BPF program attach to modules
> perf tools: Introduce strtobool() to string.c
> perf tools: Allow BPF program config probing options
> bpf tools: Load a program with different instances using preprocessor
> perf tools: Add BPF_PROLOGUE config options for further patches
> perf tools: Compile dwarf-regs.c if CONFIG_BPF_PROLOGUE is on
> perf tools: Generate prologue for BPF programs
> perf test: Test BPF prologue
> perf tools: Use same BPF program if arguments are identical
>
> tools/lib/bpf/libbpf.c | 145 ++++++++-
> tools/lib/bpf/libbpf.h | 64 ++++
> tools/perf/arch/x86/util/Build | 1 +
> tools/perf/config/Makefile | 12 +
> tools/perf/tests/Build | 9 +-
> tools/perf/tests/bpf-script-test-prologue.c | 35 +++
> tools/perf/tests/bpf.c | 34 +++
> tools/perf/tests/llvm.c | 4 +
> tools/perf/tests/llvm.h | 2 +
> tools/perf/util/Build | 1 +
> tools/perf/util/bpf-loader.c | 432 +++++++++++++++++++++++++-
> tools/perf/util/bpf-loader.h | 4 +
> tools/perf/util/bpf-prologue.c | 455 ++++++++++++++++++++++++++++
> tools/perf/util/bpf-prologue.h | 34 +++
> tools/perf/util/include/linux/string.h | 5 +
> tools/perf/util/probe-event.c | 7 +-
> tools/perf/util/probe-finder.c | 24 +-
> tools/perf/util/string.c | 28 ++
> 18 files changed, 1269 insertions(+), 27 deletions(-)
> create mode 100644 tools/perf/tests/bpf-script-test-prologue.c
> create mode 100644 tools/perf/util/bpf-prologue.c
> create mode 100644 tools/perf/util/bpf-prologue.h
>
> --
> 1.8.3.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/