Re: [PATCH] comedi: dmm32at: Fix coding style - use BIT macro

From: Dan Carpenter
Date: Mon Nov 16 2015 - 09:43:52 EST


This one is buggy. For example:

> -#define DMM32AT_FIFO_STATUS_PAGE_MASK (3 << 0)
> +#define DMM32AT_FIFO_STATUS_PAGE_MASK 0

There are other bugs as well. Please, be more careful.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/