Re: [Patch v4 2/2] media: v4l: ti-vpe: Document CAL driver

[Rob Herring]

On Sun, Nov 15, 2015 at 05:53:48PM -0600, Benoit Parrot wrote:
> Device Tree bindings for the Camera Adaptation Layer (CAL) driver

Bindings are for h/w blocks, not drivers...

> 
> Signed-off-by: Benoit Parrot <bparrot@xxxxxx>
> ---
>  Documentation/devicetree/bindings/media/ti-cal.txt | 70 ++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/media/ti-cal.txt
> 
> diff --git a/Documentation/devicetree/bindings/media/ti-cal.txt b/Documentation/devicetree/bindings/media/ti-cal.txt
> new file mode 100644
> index 000000000000..680efadb6208
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/ti-cal.txt
> @@ -0,0 +1,70 @@
> +Texas Instruments DRA72x CAMERA ADAPTATION LAYER (CAL)
> +------------------------------------------------------
> +
> +The Camera Adaptation Layer (CAL) is a key component for image capture
> +applications. The capture module provides the system interface and the
> +processing capability to connect CSI2 image-sensor modules to the
> +DRA72x device.
> +
> +Required properties:
> +- compatible: must be "ti,cal"

Needs to be more specific.

> +- reg:	physical base address and length of the registers set for the 4
> +	memory regions required;

Please list what the 4 regions are.

> +- reg-names: name associated with the memory regions described is <reg>;

Please list the names.

> +- interrupts: should contain IRQ line for the CAL;
> +
> +CAL supports 2 camera port nodes on MIPI bus. Each CSI2 camera port nodes
> +should contain a 'port' child node with child 'endpoint' node. Please
> +refer to the bindings defined in
> +Documentation/devicetree/bindings/media/video-interfaces.txt.
> +
> +Example:
> +	cal: cal@4845b000 {
> +		compatible = "ti,cal";
> +		ti,hwmods = "cal";
> +		reg = <0x4845B000 0x400>,
> +		      <0x4845B800 0x40>,
> +		      <0x4845B900 0x40>,
> +		      <0x4A002e94 0x4>;
> +		reg-names = "cal_top",
> +			    "cal_rx_core0",
> +			    "cal_rx_core1",
> +			    "camerrx_control";
> +		interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		csi2_0: port@0 {

Multiple ports should be under a ports node.

> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <0>;
> +			endpoint {
> +				slave-mode;
> +				remote-endpoint = <&ar0330_1>;
> +			};
> +		};
> +		csi2_1: port@1 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <1>;
> +		};
> +	};
> +
> +	i2c5: i2c@4807c000 {
> +		ar0330@10 {
> +			compatible = "ti,ar0330";
> +			reg = <0x10>;
> +
> +			port {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +
> +				ar0330_1: endpoint {
> +					reg = <0>;
> +					clock-lanes = <1>;
> +					data-lanes = <0 2 3 4>;
> +					remote-endpoint = <&csi2_0>;
> +				};
> +			};
> +		};
> +	};
> -- 
> 1.8.5.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/