Re: [PATCH v2 1/5] x86/mm/pageattr: Ensure cpa->pfn only contains page frame numbers

From: Dave Hansen
Date: Mon Nov 16 2015 - 10:56:24 EST

I'm glad you're looking at this. It obviously needed some love. :)

On 11/14/2015 02:00 PM, Matt Fleming wrote:
> + npages = (_end - _text) >> PAGE_SHIFT;
> + text = __pa(_text);
> + pfn = text >> PAGE_SHIFT;
> +
> + if (kernel_map_pages_in_pgd(pgd, pfn, text, npages, 0)) {
> + pr_err("Failed to map kernel text 1:1\n");
> + return 1;
> + }

Are _end and _text guaranteed to be aligned? If not, I think the
calculation might be wrong. Just for fun, imagine that _end=0xfff and
_text=0x1001. npages would be 0.

Some other code like set_kernel_text_rw() does alignment on _text.

One nit is that there's quite a bit going on here, like rearranging the
phys_stack arithmetic ordering that is far beyond just simplifying the
paddr vs. pfn issue, but that isn't called out in the changelog at all.

Your fixes all look correct to me, fwiw.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at