Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init

From: Daniel Lezcano
Date: Tue Nov 17 2015 - 07:22:59 EST

On 11/13/2015 01:20 PM, Marc Gonzalez wrote:
On 13/11/2015 11:58, Daniel Lezcano wrote:

The current code to initialize, register and read the clocksource is
already factored out in mmio.c via the clocksource_mmio_init function.

Factor out the code with the clocksource_mmio_init function.

The reason I didn't like clocksource_mmio_init() is because it exports
4 generic accessors.

I guess this function makes more sense when all platforms are using it,
in an ARCH_MULTIPLATFORM kernel. (Also the accessors are probably quite
small, so the waste is probably minimal.)

Hi Marc,

it is not clear for me if you agree with this patch or not. Can you clarify ?


-- Daniel

<> â Open source software for ARM SoCs

Follow Linaro: <> Facebook |
<!/linaroorg> Twitter |
<> Blog

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at