Re: [PATCH] perf record: Support custom vmlinux path

[pi3orama]

发自我的 iPhone

> 在 2015年11月17日，下午8:42，Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> 写道：
> 
> Em Tue, Nov 17, 2015 at 09:33:40AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Tue, Nov 17, 2015 at 09:44:44AM +0000, Wang Nan escreveu:
>> 
>> Thanks, applying.
> 
> I take that back, I think this is questionable, we should instead always
> have the --vmlinux option, and when the feature it deals with is not
> built in, warn the user about it, something like:
> 
>  #  perf record --vmlinux /a/b/c ...
>  WARNING: --vmlinux being ignored, as BPF prologue not built-in...
>  <output that can be produced while ignoring --vmlinux>
> 
> And please consider that for other options that are surrounded by ifdefs
> related to the eBPF support, there are a few more, clang related.
> 
> Also this isn't updating the perf-record man page, please do so and
> please put this in a separate section for BPF related options, something
> like:
> 
> --------------------
> 
> BPF:
> 
> These options can be used when BPF support is built-in.
> 
> ...
> 
> ---------------------
> 
> This way the user gets to know that the tool can be used with BPF while
> reading its documentation and if they decide to try it, then the
> warnings will be presented if the feature is not built-in.
> 

Ok. Thanks for your comment. I will do that tomorrow.

> - Arnaldo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/