Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb"

From: Stefan Schmidt
Date: Tue Nov 17 2015 - 11:19:48 EST


On 17/11/15 15:01, Marcel Holtmann wrote:
Hi Stefan,

The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
drivers/net/ieee802154/atusb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
index 199a94a..b1cd865 100644
--- a/drivers/net/ieee802154/atusb.c
+++ b/drivers/net/ieee802154/atusb.c
@@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb)
urb = usb_get_from_anchor(&atusb->idle_urbs);
if (!urb)
- if (urb->context)
- kfree_skb(urb->context);
+ kfree_skb(urb->context);
Acked-by: Stefan Schmidt <stefan@xxxxxxxxxxxxxxx>
for some reason I am missing the original patch, can someone resend it please.

Done. Resend the original message from my address but with the From line intact inside the patch. Please check if it really lists Markus as author when applying. Acked-by also resend as reply to the resend patch.

Stefan Schmidt
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at