Re: [PATCH] net-scm: Delete an unnecessary check before the function call "kfree"
From: David Miller
Date: Tue Nov 17 2015 - 12:10:28 EST
From: SF Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 17 Nov 2015 17:43:35 +0100
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Tue, 17 Nov 2015 17:37:22 +0100
> The kfree() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the call is not needed.
> This issue was detected by using the Coccinelle software.
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
STOP submitting this crap, NOW!
I told you I won't review nor apply these patches any more.
And ever worse, this one is BUGGY.
We're testing p->fp so we know if we can safely dereference
it or not.
You're adding an OOPS to the kernel.
This is why these mindless mechanical transformations are not
only often a waste of time, they are dangerous as well.
I am silently rejecting from patchwork, immediately, any and all
patches you submit of this nature.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/