RE: [PATCH v2 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec

[Opensource [Adam Thomson]]

On November 11, 2015 20:20, Rob Herring wrote:

> > +- dlg,micbias1-lvl : Voltage (mV) for Mic Bias 1
> > +	[<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
> <3000>]
> > +- dlg,micbias2-lvl : Voltage (mV) for Mic Bias 2
> > +	[<1200>, <1600>, <1800>, <2000>, <2200>, <2400>, <2600>, <2800>,
> <3000>]
> 
> Units please (-microvolt).

I refer back to our previous discussion (https://lkml.org/lkml/2015/10/8/661).
This doesn't add anything and makes the binding name unnecessarily long. Why is
this being enforced? Whoever uses the binding will have to look at the
documentation to understand which values are valid anyway, so this seems like
cruft.

> > +Optional properties:
> > +- dlg,jack-rate : Time between jack detect measurements (us)
> > +	[<5>, <10>, <20>, <40>, <80>, <160>, <320>, <640>]
> 
> Units

ditto.