Re: [PATCH 1/8] Documentation/spi/spidev_test.c: use one rx buffer

From: Mark Brown
Date: Tue Nov 17 2015 - 12:42:19 EST


On Tue, Nov 17, 2015 at 07:24:21AM -0800, Joshua Clayton wrote:

> default_rx and rx are needlessly different.
> Use one buffer, local to transmit()

Why? This isn't what I'd expect from black boxing the API, from a
userspace point of view the transfer is atomic and in an ideal world
we'd be able to do direct to/from memory transfers rather than memcpy()
into kernel space which means that userspace should assume the transfers
are going on simultaneously even if they don't currently.

Attachment: signature.asc
Description: PGP signature