Re: [PATCH 6/9] srp: use the new CQ API

[Bart Van Assche]

On 11/13/2015 05:46 AM, Christoph Hellwig wrote:
> +static void srp_inv_rkey_done(struct ib_cq *cq, struct ib_wc *wc)
> +{
> +	srp_handle_qp_err(cq, wc, "INV RKEY");
> +}
>
> [ ... ]
>
> +static void srp_reg_mr_done(struct ib_cq *cq, struct ib_wc *wc)
> +{
> +	srp_handle_qp_err(cq, wc, "FAST REG");
> +}

How about using names like srp_inv_rkey_err() and srp_reg_mr_err() to 
make clear that these completion functions are only called if an error 
occurred ?

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/