Re: [PATCH] USB: USB_OTG does not depend on PM

From: Peter Chen
Date: Wed Nov 18 2015 - 04:59:20 EST


On Wed, Nov 18, 2015 at 10:38:18AM +0100, Arnd Bergmann wrote:
> On Wednesday 18 November 2015 11:17:50 Peter Chen wrote:
> > From 3a6918dae038aadc200dcf0263f4440acc2353d4 Mon Sep 17 00:00:00 2001
> > From: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > Date: Wed, 18 Nov 2015 11:06:34 +0800
> > Subject: [PATCH 1/1] usb: kconfig: fix warning of select USB_OTG
> >
> > When choose randconfig for kernel build, it reports below warning:
> > "warning: (USB_OTG_FSM && FSL_USB2_OTG && USB_MV_OTG) selects USB_OTG
> > which has unmet direct dependencies (USB_SUPPORT && USB && PM)"
> >
> > In fact, USB_OTG is visual symbol and depends on PM, so the driver
>
> visible ?

Yes, will change this typo

>
> > needs to depend on it to reduce dependency problem.
> >
> > Signed-off-by: Peter Chen <peter.chen@xxxxxxxxxxxxx>
> > Reported-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Cc: Felipe Balbi <balbi@xxxxxx>
>
> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>
> I was a bit worried that this might break defconfig files that now
> no longer automatically get OSB_OTG enabled, but I have checked all
> defconfig files we have in the kernel and none of them uses
> USB_OTG_FSM, FSL_USB2_OTG or USB_MV_OTG, so we are fine.

Thanks.

>
> Thanks!
>
> Arnd

--

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/