Re: [PATCH 0/4 v2] Implement access checks in iommu page fault paths
From: Oded Gabbay
Date: Wed Nov 18 2015 - 09:08:15 EST
On Tue, Nov 17, 2015 at 5:11 PM, Joerg Roedel <joro@xxxxxxxxxx> wrote:
> here is the second version of the patch-set to implement
> proper access checks into the io-page-fault handlers of the
> AMD IOMMU and Intel VT-d drivers.
> Two additional patches clean up the AMD part a bit further.
> Since I can't test this this code myself due to lack of
> hardware or software that utilizes it, I'd appreciate some
> external testing.
> It took me a while to get these out, mostly because I tried
> to setup my own HSA test environment to at least test the
> AMD changes myself. That failed, so I am sending this out
> with another request for testing.
> Oded, Jesse, would you two please test these patches and
> report back? Thanks a lot!
> Changes since v1:
> * Updated the access_error functions based on
> Linus' feedback
> * Rebased to v4.4-rc1
> Joerg Roedel (4):
> iommu/amd: Do proper access checking before calling handle_mm_fault()
> iommu/amd: Correctly set flags for handle_mm_fault call
> iommu/amd: Cleanup error handling in do_fault()
> iommu/vt-d: Do access checks before calling handle_mm_fault()
> drivers/iommu/amd_iommu_v2.c | 54 +++++++++++++++++++++++++++-----------------
> drivers/iommu/intel-svm.c | 20 ++++++++++++++++
> 2 files changed, 53 insertions(+), 21 deletions(-)
I have very limited testing capabilities since I left AMD - I only
have Kaveri (which is kind of obsolete) and I only have a very simple
>From what I could check, I didn't see any problems, but this is really
such a very basic check that I don't even want to presume to give a
Tested-by tag. Sorry.
I suggest you talk to AMD people, as they have access to Carrizo H/W
and S/W testing framework.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/