Re: [PATCH] writeback: initialize m_dirty to avoid compile warning

From: Shi, Yang
Date: Wed Nov 18 2015 - 13:39:31 EST

On 11/18/2015 10:33 AM, Tejun Heo wrote:

On Wed, Nov 18, 2015 at 10:27:32AM -0800, Shi, Yang wrote:
This was the main reason the code was structured the way it is. If
cgroup writeback is not enabled, any derefs of mdtc variables should
trigger warnings. Ugh... I don't know. Compiler really should be
able to tell this much.

Thanks for the explanation. It sounds like a compiler problem.

If you think it is still good to cease the compile warning, maybe we could

If this is gonna be a problem with new gcc versions, I don't think we
have any other options. :(

just assign it to an insane value as what Andrew suggested, maybe

I'd just keep it at zero. Whatever we do, the effect is gonna be
difficult to track down - it's not gonna blow up in an obvious way.
Can you please add a comment tho explaining that this is to work
around compiler deficiency?


Other than this, in v2, I will just initialize m_dirty since compiler just reports it is uninitialized.



To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at