Re: [PATCH v2 1/5] crypto: Multi-buffer encryptioin infrastructure support

From: Herbert Xu
Date: Wed Nov 18 2015 - 19:13:13 EST

On Wed, Nov 18, 2015 at 07:58:56AM -0800, Tim Chen wrote:
> IPSec will invoke this multi-buffer encrypt with async request.
> The work is done in crypto daemon, so it wouldn't be in atomic
> context. But anyway, I'm okay with switching to ablkcipher walk,
> as long as it doesn't incur too much more overhead than blkcipher
> walk.

What if some other user called the blkcipher interface in an atomic
context? You can't guarantee that your algorithm is only picked up
through the ablkcipher interface, unless of course you do something
like __driver-ctr-aes-aesni.

Hmm I was just looking at the sha_mb code and something doesn't
look right. For instance, can sha1_mb_update ever return
-EINPROGRESS? This would be wrong as it's registered as an shash

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at