Re: [PATCH] PCI: Fix logic OF logic in pci_dma_configure()

From: Arnd Bergmann
Date: Thu Nov 19 2015 - 03:24:30 EST

On Wednesday 18 November 2015 16:49:52 Suravee Suthikulpanit wrote:
> - if (IS_ENABLED(CONFIG_OF) && dev->dev.of_node) {
> - if (bridge->parent)
> + bridge->parent && bridge->parent->of_node) {
> of_dma_configure(&dev->dev, bridge->parent->of_node);

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I was wondering for a bit whether we should warn about the case where there
is no of_node pointer, as that would mean we cannot do DMA on that PCI
device, but on second thought we have to do it exactly like you do, because
we would otherwise break machines that do not use DT.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at