Re: [PATCH v2 2/5] Documentation: devicetree: Add DT bindings to eeprom_93xx46 driver.

From: Rob Herring
Date: Thu Nov 19 2015 - 09:59:33 EST


On Wed, Nov 18, 2015 at 10:29:38PM -0500, Cory Tusar wrote:
> This commit documents bindings to be added to the eeprom_93xx46 driver
> which will allow:
>
> - Device word size and read-only attributes to be specified.
> - A device-specific compatible string for use with Atmel AT93C46D
> EEPROMs.
> - Specifying a GPIO line to function as a 'select' or 'enable' signal
> prior to accessing the EEPROM.
>
> Signed-off-by: Cory Tusar <cory.tusar@xxxxxxxxxxxxxxxxx>

One nit, but:

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> ---
> .../devicetree/bindings/misc/eeprom-93xx46.txt | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> new file mode 100644
> index 0000000..8e116a1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/eeprom-93xx46.txt
> @@ -0,0 +1,25 @@
> +EEPROMs (SPI) compatible with Microchip Technology 93xx46 family.
> +
> +Required properties:
> +- compatible : shall be one of:
> + "atmel,at93c46d"
> + "eeprom-93xx46"
> +- data-size : number of data bits per word (either 8 or 16)
> +
> +Optional properties:
> +- read-only : parameter-less property which disables writes to the EEPROM
> +- select-gpios : if present, specifies the GPIO that will be asserted prior to
> + each access to the EEPROM (e.g. for SPI bus multiplexing)
> +
> +Property rules described in Documentation/devicetree/bindings/spi/spi-bus.txt
> +apply. In particular, "reg" and "spi-max-frequency" properties must be given.
> +
> +Example:
> + 93c46c@0 {

This should be eeprom@0.

> + compatible = "eeprom-93xx46";
> + reg = <0>;
> + spi-max-frequency = <1000000>;
> + spi-cs-high;
> + data-size = <8>;
> + select-gpios = <&gpio4 4 GPIO_ACTIVE_HIGH>;
> + };
> --
> 2.4.10
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/