[PATCH] null_blk: fix ifnullfree.cocci warnings

From: kbuild test robot
Date: Thu Nov 19 2015 - 17:11:14 EST


drivers/block/null_blk.c:850:2-20: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

NULL check before some freeing functions is not needed.

Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Matias Bjørling <m@xxxxxxxxxxx>
Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
---

null_blk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/block/null_blk.c
+++ b/drivers/block/null_blk.c
@@ -846,8 +846,7 @@ static void __exit null_exit(void)
}
mutex_unlock(&lock);

- if (ppa_cache)
- kmem_cache_destroy(ppa_cache);
+ kmem_cache_destroy(ppa_cache);
}

module_init(null_init);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/