Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions

[Nadav Amit]

Wanpeng Li <kernellwp@xxxxxxxxx> wrote:

> 2015-11-20 10:52 GMT+08:00 Wanpeng Li <kernellwp@xxxxxxxxx>:
>> Hi Paolo,
>> 2015-02-09 17:03 GMT+08:00 Paolo Bonzini <pbonzini@xxxxxxxxxx>:
>>> NoWrite instructions (e.g. cmp or test) never set the "write access"
>>> bit in the error code, even if one of the operands is treated as a
>>> destination.
>> 
>> Sorry to reply to an old commit, btw, could you point out where in SDM
>> describe above?
> 
> I see.

I donât understand whether you still need my help, so to clarify: on a
page-fault the error code should indicate whether the access was due to a
write access. Previously KVM marked it as âwrite accessâ for instructions
such as test and cmp that do not perform write.

Nadav--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/