RE: [PATCH v11 3/8] Input: goodix - write configuration data to device

From: Tirdea, Irina
Date: Fri Nov 20 2015 - 08:13:16 EST




> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx]
> Sent: 19 November, 2015 20:21
> To: Tirdea, Irina
> Cc: Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@xxxxxxxxxxxxxxx; Mark Rutland; Rob Herring; Purdila, Octavian; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v11 3/8] Input: goodix - write configuration data to device
>
> On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote:
> > + if (ts->gpiod_int && ts->gpiod_rst) {
> > + /* update device config */
> > + ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin",
> > + ts->id);
>
> devm_kasprintf maybe (don't resubmit)?
>

Yes, using devm_kasprintf would be better.

Thanks,
Irina

> Thanks.
>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/