[PATCH v2 3/3] serial: xuartps: Do not enable parity error interrupt

From: Nava kishore Manne
Date: Fri Nov 20 2015 - 08:50:40 EST

The patch makes changes not to enable parity error interrupt.
With the current implementation, each parity error results in
two distinct interrupts (almost always). The first one is normal
parity error interrupt with no data in the fifo and the second one
is a proper Rx interrupt with the received data in the fifo. By
disabling parity error interrupt we still ensure handling of
parity errors as for the Rx fifo interrupt the parity error still
shows up in the interrupt status register. Considering the fact
that the by default INPCK and IGNPAR are not set, this is the
optimal implementation for parity error handling.

Signed-off-by: Nava kishore Manne <navam@xxxxxxxxxx>
Changes for v2:

drivers/tty/serial/xilinx_uartps.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 4d71478..082e7f7 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -824,8 +824,18 @@ static int cdns_uart_startup(struct uart_port *port)
writel(readl(port->membase + CDNS_UART_ISR_OFFSET),
port->membase + CDNS_UART_ISR_OFFSET);

- /* Set the Interrupt Registers with desired interrupts */
+ /*
+ * Set the Interrupt Registers with desired interrupts. Do not
+ * enable parity error interrupt for the following reason:
+ * When parity error interrupt is enabled, each Rx parity error always
+ * results in 2 events. The first one being parity error interrupt
+ * and the second one with a proper Rx interrupt with the incoming data.
+ * Disabling parity error interrupt ensures better handling of parity
+ * error events. With this change, for a parity error case, we get a
+ * Rx interrupt with parity error set in ISR register and we still
+ * handle parity errors in the desired way.
+ */
port->membase + CDNS_UART_IER_OFFSET);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/