Re: [PATCH 1/1] soc: ti: knav_qmss_queue: Fix linking RAM setup for queue managers

From: santosh shilimkar
Date: Fri Nov 20 2015 - 18:48:21 EST

On 11/20/2015 3:39 PM, Michal Morawiec wrote:
Configure linking RAM for both queue managers also in case
when only linking RAM 0 is specified in device tree.

why ?

Signed-off-by: Michal Morawiec <michal.1.morawiec.ext@xxxxxxxxx>
drivers/soc/ti/knav_qmss_queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index 6d8646d..a809c30 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -1173,7 +1173,7 @@ static int knav_queue_setup_link_ram(struct knav_device *kdev)

if (!block->size)
- return 0;
+ continue;

You have to expand this a bit for me. Because you really don't
want kernel code to run the configuration on hardware which doesn't
exist. I mean device tree suppose to specify the linking RAM for both
QMs unless and until there is a reason not too.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at