Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC

[Andrew F. Davis]

On 11/21/2015 07:37 AM, Mark Brown wrote:
> On Thu, Nov 19, 2015 at 05:01:41PM -0600, Andrew F. Davis wrote:
> > Add support for TPS65086 PMIC regulators.
> >
> > The regulators set consists of 3 Step-down Controllers, 3 Step-down
> > Converters, 3 LDOs, 3 Load Switches, and a Sink and Source LDO. The
> > output voltages are configurable and are meant to supply power to a
> > SoC and/or other components.
>
> An earlier version of this patch has already been applied, please don't
> resend already applied patches but send incremental patches with any
> changes.

Odd, I didn't seem to get any message for this getting applied. Looks
like only a couple lines difference from the version in the regulators
branch, I don't imagine you are able to rebase that with these changes?

Anyway the reason that line needed changed is over a confusion in
what the 'of_node' does in 'struct regulator_config'. The description
seems to make it seem like it is the node that gets checked for
init data.

> * @of_node: OpenFirmware node to parse for device tree bindings (may be
> *           NULL).

But the 'of_node' that is actually searched is the one given in
regulator_config->dev->of_node. Is this intended behavior (drivers
assume it is so it probably has to be now) and if so, the above
description might need to be clarified as too what that 'of_node'
pointer really does?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/