Re: [PATCH 1/3] rtc: sunxi: fix signedness issues

From: Chen-Yu Tsai
Date: Mon Nov 23 2015 - 02:19:00 EST

On Thu, Nov 19, 2015 at 6:50 PM, LABBE Corentin
<clabbe.montjoie@xxxxxxxxx> wrote:
> The variable year must be set as unsigned since it is used with
> sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which
> wait for unsigned int.
> Only tm_year is not unsigned, but it is long.
> This patch fix also the format of printing of min/max. (must use %u since
> they are unsigned)
> The parameter to of sunxi_rtc_setaie() must be set to uint since callers
> give always uint data.
> Signed-off-by: LABBE Corentin <clabbe.montjoie@xxxxxxxxx>

Acked-by: Chen-Yu Tsai <wens@xxxxxxxx>

Would've preferred you not changing the whitespace on the dev_err line though.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at