Re: [PATCH 1/2] arch: consolidate CONFIG_STRICT_DEVM in lib/Kconfig.debug

From: Heiko Carstens
Date: Mon Nov 23 2015 - 04:53:20 EST


On Sat, Nov 21, 2015 at 07:57:02PM -0800, Dan Williams wrote:
> Let all the archs that implement CONFIG_STRICT_DEVM use a common
> definition in lib/Kconfig.debug.
>
> Note, the 'depends on !SPARC' is due to sparc not implementing
> devmem_is_allowed().
>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxxx>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx>
> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>
> Suggested-by: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> ---
> arch/arm/Kconfig.debug | 14 --------------
> arch/arm64/Kconfig.debug | 14 --------------
> arch/powerpc/Kconfig.debug | 12 ------------
> arch/s390/Kconfig.debug | 12 ------------
> arch/tile/Kconfig | 3 ---
> arch/unicore32/Kconfig.debug | 14 --------------
> arch/x86/Kconfig.debug | 17 -----------------
> lib/Kconfig.debug | 19 +++++++++++++++++++
> 8 files changed, 19 insertions(+), 86 deletions(-)

For s390

Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx>

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8c15b29d5adc..ad85145d0047 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1853,3 +1853,22 @@ source "samples/Kconfig"
>
> source "lib/Kconfig.kgdb"
>
> +config STRICT_DEVMEM
> + bool "Filter access to /dev/mem"
> + depends on MMU
> + depends on !SPARC
> + default y if TILE || PPC || S390

I wouldn't mind if you would remove s390 from this list.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/