Re: [PATCH] PCI: MSI: Only use the generic MSI layer when domain is hierarchical

From: Thomas Gleixner
Date: Mon Nov 23 2015 - 12:39:19 EST

On Mon, 23 Nov 2015, Marc Zyngier wrote:

> Since d8a1cb757550 ("PCI/MSI: Let pci_msi_get_domain use struct
> device::msi_domain"), we use the MSI domain associated to the PCI device.
> But finding a MSI domain doesn't mean that the domain is implemented
> using the generic MSI domain API, and a number of MSI controllers
> are still using the arch_setup_msi_irq/arch_teardown_msi_irqs.
> In order to avoid a firework on these systems, check that the domain
> we just obtained is hierarchical. If not, don't use the generic MSI
> stuff and stick with the old one. Not pretty, but reliable.
> Another insentive to rework those drivers and phase out this API.
> Reported-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> Tested-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>

Acked-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at