Re: [PATCH 2/2] ptrace: task_stopped_code(ptrace => true) can't see TASK_STOPPED task

From: Tejun Heo
Date: Mon Nov 23 2015 - 18:15:46 EST


On Thu, Nov 19, 2015 at 07:47:52PM +0100, Oleg Nesterov wrote:
> task_stopped_code()->task_is_stopped_or_traced() doesn't look right,
> the traced task must never be TASK_STOPPED.
>
> We can not add WARN_ON(task_is_stopped(p)), but this is only because
> do_wait() can race with PTRACE_ATTACH from another thread.
>
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

I think it's a left over from before. We used to leave STOPPED tasks
alone during ptrace attach.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/