Re: [PATCH 1/3] zram/zcomp: use GFP_NOIO to allocate streams

From: Minchan Kim
Date: Tue Nov 24 2015 - 02:10:59 EST


On Tue, Nov 24, 2015 at 03:00:37PM +0900, Sergey Senozhatsky wrote:
> [..]
> > static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp)
> > {
> > - struct zcomp_strm *zstrm = kmalloc(sizeof(*zstrm), GFP_KERNEL);
> > + struct zcomp_strm *zstrm = kmalloc(sizeof(*zstrm), GFP_NOIO);
> > if (!zstrm)
> > return NULL;
> >
> > @@ -85,7 +85,7 @@ static struct zcomp_strm *zcomp_strm_alloc(struct zcomp *comp)
> > * allocate 2 pages. 1 for compressed data, plus 1 extra for the
> > * case when compressed size is larger than the original one
> > */
> > - zstrm->buffer = (void *)__get_free_pages(GFP_KERNEL | __GFP_ZERO, 1);
> > + zstrm->buffer = (void *)__get_free_pages(GFP_NOIO | __GFP_ZERO, 1);
> > if (!zstrm->private || !zstrm->buffer) {
> > zcomp_strm_free(comp, zstrm);
> > zstrm = NULL;
>
> hm... this is not enough.
> we allocate
>
> stream GFP_NOIO
> stream private GFP_KERNEL <<<< still old flags
> stream buffer
>
> so my patch was something like this:

Oops, I missed that. Sorry.
I will include it in next spin.

Thanks!
--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/