Re: [PATCH v5 5/8] watchdog: Simplify update_worker

[Guenter Roeck]

Hi Uwe,

On 11/23/2015 11:13 PM, Uwe Kleine-König wrote:
> Hello,
>
> On Sun, Nov 22, 2015 at 07:21:02PM -0800, Guenter Roeck wrote:
> > Drop 'cancel' parameter; simply cancel worker unconditionally
> > if not needed.
> >
> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>
> This is a good change, but given that watchdog_update_worker is
> introduced in this series it should be squashed accordingly.

As I tried to explain, I didn't squash it because, even though
I could not find any trouble with it, I am still not sure if
it may cause trouble or not. As such, I found it better to keep
it separate to make it easier to revert it _if_, as unlikely as
it may be, it should be needed.

Ultimately I'd like to get some input from Wim on this.

Thanks,
Guenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/