Re: [PATCH] modpost: don't add a trailing wildcard for OF module aliases

[Sjoerd Simons]

On Thu, 2015-11-19 at 11:28 -0300, Javier Martinez Canillas wrote:
> Âscripts/mod/file2alias.c | 3 +--
> Â1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index 5b96206e9aab..65eaab8b7798 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -125,7 +125,7 @@ do
> {ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂsprintf(str + strlen(str), "*");ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ\
> Â} while(0)
> Â
> -/* Always end in a wildcard, for future extension */
> +/* End in a wildcard, for future extension */
> Âstatic inline void add_wildcard(char *str)
> Â{
> Â	int len = strlen(str);
> @@ -704,7 +704,6 @@ static int do_of_entry (const char *filename,
> void *symval, char *alias)
> Â		if (isspace (*tmp))
> Â			*tmp = '_';
> Â
> -	add_wildcard(alias);
> Â	return 1;
> Â}
> ÂADD_TO_DEVTABLE("of", of_device_id, do_of_entry);

Reviewed-by: Sjoerd Simons <sjoerd.simons@xxxxxxxxxxxxxxx>

-- 
Sjoerd Simons
Collabora Ltd.