Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC

From: Mark Brown
Date: Tue Nov 24 2015 - 07:12:24 EST


On Mon, Nov 23, 2015 at 01:18:15PM -0600, Andrew F. Davis wrote:

> Right, so this is the kind of description that would be nice with the
> declaration.

Feel free to send patches for the documentation, bearing in mind that
there is a limit to how large we cna make it.

> >>in the config takes precedence over the one in config->dev, the
> >>opposite is true for regulators, this is very confusing and should be
> >>standardized.

> >No, they both do the same thing.

> I don't see that, config->dev->of_node is checked for the init data in
> regulator_of_get_init_data, then config->of_node is then ignored if that
> succeeds.

Right, like I say this is because nobody should ever actually be using
that capability if they also have good bindings. If anyone did have a
sensible use case that'd be where it would go but as things stand they
will be pushed to do the right thing.

Attachment: signature.asc
Description: PGP signature