Re: block-rbd: One function call less in rbd_dev_probe_parent() after error detection

[SF Markus Elfring]

> Well, there isn't any _literal_ linking (e.g. adding to a link list,
> etc) in this case.  We just bump some refs and do probe to fill in the
> newly allocated parent.

Thanks for your clarification.


> The actual linking (rbd_dev->parent = parent) is done right before
> returning so we never have to undo it in rbd_dev_probe_parent() and
> that's the only reason your patch probably doesn't break anything.

Is this function implementation just also affected by an issue
which is mentioned in the Linux document "CodingStyle" as "one err bugs"?


> Think about what happens if, after your patch is applied, someone moves
> that assignment up or adds an extra step that can fail after it...

Is such a software maintenance concern really enough to delay (or reject)
my second update suggestion in this small patch series?

Regards,
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/